test(e2e): delete MantleBackups after backup-failure tests to avoid interfering with subsequent tests#287
Merged
Conversation
skoya76
changed the title
skoya76
force-pushed
the
fix-backup-failure-test-flakiness
branch
from
ad07ebc to
a1e68af
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the multi-cluster e2e “backup-failure” test suite to prevent residual MantleBackup resources from leaking between test cases by ensuring the test namespaces are deleted at the end of each failure scenario.
Changes:
- Added a
TearDownEnvironment(namespace)helper to delete the test namespace in both primary and secondary clusters. - Registered
DeferCleanuphooks inbackup_failure_test.goso teardown runs automatically after each backup-failure test case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/e2e/multik8s/testutil/util.go |
Adds TearDownEnvironment helper to delete namespaces in both clusters. |
test/e2e/multik8s/backup_failure_test.go |
Adds DeferCleanup calls to ensure namespaces are cleaned up after each test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skoya76
force-pushed
the
fix-backup-failure-test-flakiness
branch
2 times, most recently
from
9ee74c3 to
1b9d58d
Compare
skoya76
changed the title
skoya76
requested review from
llamerada-jp and
ushitora-anqou
and removed request for
a team and
ushitora-anqou
llamerada-jp
requested changes
May 29, 2026
llamerada-jp
left a comment
llamerada-jp
left a comment
Contributor
There was a problem hiding this comment.
If you fail a CI, you may want to study the root cause using existing resources. It's better to keep the resource in that case. So, I suggest that you put CleanupMantleBackups without DeferCleanup at the end of test scenarios.
skoya76
force-pushed
the
fix-backup-failure-test-flakiness
branch
from
1b9d58d to
4154364
Compare
…nterfering with subsequent tests The test "should handle removal of MantleBackup in secondary k8s cluster during an incremental backup" was failing with a timeout. When the previous test (primary MantleBackup deletion scenario) finishes, a residual secondary MantleBackup is left behind in "waiting for export data" state because its primary was deleted before the upload completed. When the next test pauses RGW, the secondary reconciler gets blocked on S3 operations triggered by processing this residual MantleBackup, causing `kubectl delete --timeout=3m` issued against the current test's secondary MantleBackup to expire before finalizeSecondary could run. Add CleanupMantleBackups to delete all MantleBackups on both clusters at the end of each backup-failure test via DeferCleanup, so that no residual MantleBackups remain when the next test starts. Signed-off-by: Kohya Shiozaki <kouyan120706@gmail.com>
skoya76
force-pushed
the
fix-backup-failure-test-flakiness
branch
from
4154364 to
3fbb1a9
Compare
Contributor
Author
|
Thanks, I changed it to clean up at the end of each test scenario. |
llamerada-jp
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test "should handle removal of MantleBackup in secondary k8s cluster
during an incremental backup" was failing with a timeout.
When the previous test (primary MantleBackup deletion scenario) finishes, a
residual secondary MantleBackup is left behind in "waiting for export
data" state because its primary was deleted before the upload completed. When
the next test pauses RGW, the secondary reconciler gets blocked on S3
operations triggered by processing this residual MantleBackup, causing
kubectl delete --timeout=3missued against the current test's secondaryMantleBackup to expire before finalizeSecondary could run.
Add CleanupMantleBackups to delete all MantleBackups on both clusters at the
end of each backup-failure test via DeferCleanup, so that no residual
MantleBackups remain when the next test starts.